search

l3r8yJ / oop-cop

The static analysis tool and a Maven plugin that will help you model your objects, classes, methods properly by rejecting your non-perfect code.
https://www.l3r8y.ru/oop-cop/
MIT License
9 stars 5 forks source link

java 17 support #129

Closed h1alexbel closed 6 months ago

h1alexbel commented 8 months ago

ref: #102

PR-Codex overview

This PR focuses on updating the Java version used in the project.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 8 months ago

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (59261bc) 78.24% compared to head (8185694) 78.24%. Report is 2 commits behind head on master.

:exclamation: Current head 8185694 differs from pull request most recent head 64db521. Consider uploading reports for the commit 64db521 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ========================================= Coverage 78.24% 78.24% Complexity 79 79 ========================================= Files 21 21 Lines 239 239 Branches 10 10 ========================================= Hits 187 187 Misses 46 46 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zoeself commented 8 months ago

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-01-11T08:40:04.230019.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

zoeself commented 8 months ago

@l3r8yJ Don't forget to close this ticket before the deadline (2024-01-11T08:40:04). You are past the first half of the allowed period.

zoeself commented 8 months ago

@l3r8yJ Looks like you've missed the task deadline (2024-01-11T08:40:04). You are now resigned from this task.

Please stop working on it, you will not be paid. I will assign it to someone else soon.

zoeself commented 8 months ago

@l3r8yJ I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.