l3r8yJ / oop-cop

The static analysis tool and a Maven plugin that will help you model your objects, classes, methods properly by rejecting your non-perfect code.
https://www.l3r8y.ru/oop-cop/
MIT License
9 stars 5 forks source link

LinkedComplaint and ClassifiedComplaint #130

Closed h1alexbel closed 8 months ago

h1alexbel commented 8 months ago

@l3r8yJ take a look, please closes #117


PR-Codex overview

This PR focuses on improving the code diff by introducing the ClassifiedComplaint and LinkedComplaint classes.

Detailed summary:

The following files were skipped due to too many changes: src/test/java/ru/l3r8y/complaint/ClassifiedComplaintTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 8 months ago

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

zoeself commented 8 months ago

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-01-11T13:10:05.018212.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

h1alexbel commented 8 months ago

@l3r8yJ take a look, please once again and re-run codecov GHA

h1alexbel commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@h1alexbel Thanks for your request; @l3r8yj please confirm this.

l3r8yJ commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 months ago

@rultor merge

@l3r8yj Done! FYI, the full log is here (took me 2min)

zoeself commented 8 months ago

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.