search

l3r8yJ / oop-cop

The static analysis tool and a Maven plugin that will help you model your objects, classes, methods properly by rejecting your non-perfect code.
https://www.l3r8y.ru/oop-cop/
MIT License
9 stars 5 forks source link

Suppressible checks resolving, Consistent naming #131

Closed h1alexbel closed 8 months ago

h1alexbel commented 8 months ago

closes #127

PR-Codex overview

This PR focuses on renaming the ru.l3r8y.rule package to ru.l3r8y.checks.

Detailed summary

The following files were skipped due to too many changes: src/main/java/ru/l3r8y/rule/MethodChangesState.java, src/main/java/ru/l3r8y/ValidateMojo.java, src/main/java/ru/l3r8y/rule/AssigmentCheck.java, src/main/java/ru/l3r8y/checks/ClassCanSuppress.java, src/test/java/ru/l3r8y/checks/ClassCanSuppressTest.java, src/test/java/ru/l3r8y/rule/MethodChangesStateTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 8 months ago

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (64d72cd) 80.64% compared to head (3da1c02) 81.10%.

Files Patch % Lines
src/main/java/ru/l3r8y/ValidateMojo.java 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #131 +/- ## ============================================ + Coverage 80.64% 81.10% +0.45% - Complexity 85 88 +3 ============================================ Files 23 24 +1 Lines 248 254 +6 Branches 10 10 ============================================ + Hits 200 206 +6 Misses 42 42 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zoeself commented 8 months ago

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-01-12T12:30:27.665550.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel commented 8 months ago

@l3r8yJ please take a look

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

l3r8yJ commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 months ago

@rultor merge

@l3r8yj Done! FYI, the full log is here (took me 2min)

zoeself commented 8 months ago

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.