138 - Githubissues

l3r8yJ / oop-cop

The static analysis tool and a Maven plugin that will help you model your objects, classes, methods properly by rejecting your non-perfect code.

https://www.l3r8y.ru/oop-cop/

MIT License

9 stars 5 forks source link

138 #139

Closed l3r8yJ closed 6 months ago

l3r8yJ commented 6 months ago

closes #138

PR-Codex overview

This PR focuses on refactoring the code to improve readability and maintainability.

Detailed summary

Updated formatting of string messages in LinkedComplaint and BulkComplaint
Renamed CompoundComplaint to BulkComplaint
Updated references to CompoundComplaint in ValidateMojo and CompoundComplaintTest
Updated string messages in verify.groovy files
Added dependencies for Guava, AspectJ, and jcabi-aspects
Added jcabi-maven-plugin for AspectJ weaving
Added ScannedChecks class for scanning and retrieving all check names

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 6 months ago

@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

sonarcloud[bot] commented 6 months ago

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b492b68) 81.10% compared to head (1427e6a) 81.67%.

Files	Patch %	Lines
src/main/java/ru/l3r8y/ValidateMojo.java	0.00%	1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #139 +/- ## ============================================ + Coverage 81.10% 81.67% +0.57% - Complexity 88 95 +7 ============================================ Files 24 25 +1 Lines 254 262 +8 Branches 10 10 ============================================ + Hits 206 214 +8 Misses 42 42 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

l3r8yJ commented 6 months ago

@rultor merge

rultor commented 6 months ago

@rultor merge

@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 months ago

@rultor merge

@l3r8yj Done! FYI, the full log is here (took me 3min)