search

l3r8yJ / oop-cop

The static analysis tool and a Maven plugin that will help you model your objects, classes, methods properly by rejecting your non-perfect code.
https://www.l3r8y.ru/oop-cop/
MIT License
9 stars 5 forks source link

feat(class-name-check): added actual length to the message #176

Closed l3r8yJ closed 3 months ago

l3r8yJ commented 3 months ago

closes #175

PR-Codex overview

This PR enhances the LongClassNameCheck by providing the actual length of the class name and suggests using a shorter name. It also updates the verification message in the test file.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 3 months ago

@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.48%. Comparing base (1fe2f96) to head (3986f36).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #176 +/- ## ============================================ + Coverage 81.41% 81.48% +0.06% Complexity 94 94 ============================================ Files 25 25 Lines 269 270 +1 Branches 10 10 ============================================ + Hits 219 220 +1 Misses 44 44 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

l3r8yJ commented 3 months ago

@rultor merge

zoeself commented 3 months ago

@l3r8yJ I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

rultor commented 3 months ago

@rultor merge

@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 months ago

@rultor merge

@l3r8yj Done! FYI, the full log is here (took me 4min)