search

l3rady / wp-updates-notifier

Sends email to notify you if there are any updates for your WordPress site. Can notify about core, plugin and theme updates.
29 stars 22 forks source link

PHP Strict Standards #24

Open stevengliebe opened 8 years ago

stevengliebe commented 8 years ago

Whenever I check debug.log I find many entries relating to WP Updates Notifier. I don't think these are major issues but could probably be tidied up. I assume it has to do with later versions of PHP. I see these on PHP Version 5.6.13.

I'll submit a pull request if I can find some time but thought I'd post an issue in case somebody else wants to get to it before me.

[12-Nov-2015 13:40:12 UTC] PHP Strict Standards: Non-static method sc_WPUpdatesNotifier::log_last_check_time() should not be called statically in /home/user/public_html/demos/wp-content/plugins/wp-updates-notifier/wp-updates-notifier.php on line 240

[12-Nov-2015 14:49:32 UTC] PHP Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method sc_WPUpdatesNotifier::do_update_check() should not be called statically in /home/user/public_html/demos/wp-includes/plugin.php on line 579

[12-Nov-2015 14:49:34 UTC] PHP Strict Standards: Non-static method sc_WPUpdatesNotifier::themes_update_check() should not be called statically in /home/user/public_html/demos/wp-content/plugins/wp-updates-notifier/wp-updates-notifier.php on line 229

EvanHerman commented 8 years ago

Thank you for posting that here Steven. I am going to do a bit of cleanup today and will have a look into the issues you have mentioned above.

Evan

stevengliebe commented 8 years ago

Wonderful, thank you! It's been a very helpful plugin to me. This would really polish it off.

goatherd commented 8 years ago

Can not use the plugin with PHP 7 and unable to use in development environment with PHP 5.4+ due to log/ screen spam.

Is there any intend to fix this and use PHP 5+ notation? (basically the notices say that you use PHP4-style coding that completely ignores object orientation design)

timatron commented 4 years ago

This issue should be closed.