search

l3uddz / plex_autoscan

Script to assist sonarr/radarr with plex imports. Will only scan the folder that has been imported, instead of the whole library section.
GNU General Public License v3.0
395 stars 70 forks source link

Feature: Add Windows Support #136

Closed beyondmeat closed 4 years ago

beyondmeat commented 4 years ago

Fix: Windows doesn't support setting encoding Feature: Support Environment vars for config paths Config: Add Windows specific example

desimaniac commented 4 years ago

Old readme had some info on Windows. https://github.com/l3uddz/plex_autoscan/blob/master/README.bak.md

But none of use a Windows anymore, so doubtful we'll be able to write much about.

beyondmeat commented 4 years ago

@desimaniac This PR fixes 2 windows bugs, allows using environment vars (less config editing needed now) and generates a windows specific config if on Windows.

Tested and Working for me.

beyondmeat commented 4 years ago

I have updated the readme

desimaniac commented 4 years ago

Ok didn't realize this was a PR and not an Feature Request 😛.

I'll take a look at tomorrow.

desimaniac commented 4 years ago

Can you split 'Feature: Support Environment vars for config paths' into its own PR? I think it could be file done directly under config. Py module in load function. No need to rushed it in every instance of the variable call.

If you split that up, I could merge the others and we can work on this feature separately.

Also didn't see 'merge_two_dicts(x, y)' being used anywhere.