search

l3uddz / plex_autoscan

Script to assist sonarr/radarr with plex imports. Will only scan the folder that has been imported, instead of the whole library section.
GNU General Public License v3.0
396 stars 70 forks source link

Ported module imports to Python3 equivalents, cleared up a whitespace warning. #82

Closed sabrsorensen closed 5 years ago

sabrsorensen commented 5 years ago

I've packaged this service into a Docker container based on Arch Linux, sabrsorensen/arch-plex_autoscan. The Arch Linux package for python2-pip hasn't been updated to handle the changes to the helpers libraries in python2-progress, so installing python2-pip when building my container will fail. To address this, I made some minor changes to update to the Python3 equivalent modules and cleared up a tab vs space warning I received when trying to launch under Python3.

sabrsorensen commented 5 years ago

I've tested these changes in my setup and verified scans still process as expected. I'm not sure how to convert this from a Draft PR, there is no "Ready for Review" button like the Github documentation says.

sabrsorensen commented 5 years ago

Never mind, you've already addressed most of these changes in feature/google-rewrite.

desimaniac commented 5 years ago

Can you test your docker image with that feature branch?

sabrsorensen commented 5 years ago

I can, first layer of the onion is the Queue module import needs to be made Python3-friendly, so I'll branch off feature/google-rewrite in my fork to track what's needed to dockerize that branch.

sabrsorensen commented 5 years ago

I'm closing this PR to reopen from my Python3 version of feature/google-rewrite, which as already based on the feature branch.