search

l3uddz / traktarr

Script to add new series & movies to Sonarr/Radarr based on Trakt lists.
GNU General Public License v3.0
576 stars 52 forks source link

--dry-run option to show what would happen #119

Open dkids opened 4 years ago

dkids commented 4 years ago

I left the house with Traktarr scheduled to run. When I came home, my disk had filled up because of the number of series added. Also, activity.log showed this:

2020-02-09 15:24:53,754 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'High School Musical (2006)' 2020-02-09 15:24:53,755 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'The Descendants (2011)' 2020-02-09 15:24:53,755 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'That Awkward Moment (2014)' 2020-02-09 15:24:53,755 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'Colombiana (2011)' 2020-02-09 15:24:53,755 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'The Transporter Refueled (2015)'

That was scary but it turned out that the movies hadn't been removed

Programs like rsync have a "--dry-run" option which shows what the result would be if the command was executed. It's not clear to me why Traktarr thought it should remove those movies and I'd like to be able to safely debug.

I wouldn't mind a configuration option for "allow_delete: no" so that it was clear that I don't want Traktarr touching my existing files.

Thanks!

desimaniac commented 4 years ago

It was NOT removing movies from Radarr.. It was getting a list of movies from Radarr and then removing them from the list of movies that came in from Traktarr.

desimaniac commented 4 years ago

Will tweak the log to show that it's removing movies from the Trakt list, not Radarr.

Could also look into a dry-run for the purposes of seeing what would be added or not, etc.

dkids commented 4 years ago

Thank you!

I'm not sure if you want to put a configuration option for # of lines in the log file. All I had in activity.log were the "removed" entries. So there was a lot of activity but I couldn't see some of what happened, like where series or movies were added.

desimaniac commented 4 years ago

You have debug enabled. You’ll get more info than you need with that.

croax commented 3 years ago

+1 for having --dry-run available, would be great to see what happends after changing the configuration instead of waiting for the next interval which takes no less than 1 hour.