search

l4ka / pistachio

L4Ka::Pistachio micro-kernel
http://l4ka.org/projects/pistachio
273 stars 54 forks source link

reserved identifier violation #12

Open elfring opened 10 years ago

elfring commented 10 years ago

Can it be that identifiers like "__SYNC_H__" and "__KICKSTART__KICKSTART_H__" do not fit to the expected naming convention of the C++ language standard? Would you like to adjust your selection for unique names?

jkehne commented 10 years ago

You are right, these do violate the C++ standard. I assume I will fix them eventually, but given this hasn't caused any problems so far, please understand that it won't be my top priority.

elfring commented 10 years ago

How do you think about to avoid that this software depends on undefined behaviour?

jkehne commented 10 years ago

Just to be clear: I do agree with you, and I will fix this eventually. However, I have more important things on my mind right now, so the fix will have to wait. If you would like to see this fixed more quickly, you are of course welcome to send me a patch.