Panic when no apps match query

l4l / yofi

yofi is a minimalistic menu for wayland

https://crates.io/crates/yofi

MIT License

337 stars 22 forks source link

Panic when no apps match query #148

Closed BlockListed closed 9 months ago

BlockListed commented 9 months ago

Recreate:

Open yofi
Type something, where no apps match the query
Press enter and a panic will happen.

Problem:

When this panic occurs, the yofi interface doesn't close, which makes it take over all keyboard and mouse input, until I kill yofi.

l4l commented 9 months ago

I cannot reproduce that.

Could you give a backtrace (e.g launch with gdb or just pstack)?
Do you have notify-send binary and it's working fine on it's own?

BlockListed commented 9 months ago

I cannot reproduce that.

1. Could you give a backtrace (e.g launch with gdb or just pstack)?

2. Do you have notify-send binary and it's working fine on it's own?

The notify-send binary hangs on my system (arch x86_64) when there is no notification daemon. This issue was a misdiagnosis of the actual problem, which was notify-send being called without a timeout when panicking. I addressed this in my companion PR #149 .