l7mp / stunner

A Kubernetes media gateway for WebRTC. Contact: info@l7mp.io
https://l7mp.io
MIT License
751 stars 58 forks source link

Issue in installation document #176

Closed mahdidarabi closed 1 week ago

mahdidarabi commented 2 weeks ago

Description

The url of installation of CRDs for K8s gateway-api is invalid

Steps to Reproduce

Run below command from document: kubectl apply -k github.com/kubernetes-sigs/gateway-api/config/crd?ref=v1.0.0

Expected behavior: Installation of gateway-api CRDs to be complete.

Actual behavior: Throws error with this msg: no matches found: github.com/kubernetes-sigs/gateway-api/config/crd?ref=v1.0.0

Versions

1.0.0

levaitamas commented 2 weeks ago

Hi @mahdidarabi !

Thanks for letting us know. @davidkornel could this (v1.0.0, standtard-install) be a valid alternative: https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.0.0/standard-install.yaml ?

davidkornel commented 2 weeks ago

Reopening: Although it has been fixed and closed I am still curious

Hi @mahdidarabi and @levaitamas.

This seems confusing, as it works for me:

kubectl apply -k github.com/kubernetes-sigs/gateway-api/config/crd?ref=v1.0.0
customresourcedefinition.apiextensions.k8s.io/gatewayclasses.gateway.networking.k8s.io configured
customresourcedefinition.apiextensions.k8s.io/gateways.gateway.networking.k8s.io configured
customresourcedefinition.apiextensions.k8s.io/httproutes.gateway.networking.k8s.io configured
customresourcedefinition.apiextensions.k8s.io/referencegrants.gateway.networking.k8s.io configured

Tamás you're right, that is an alternative; however, why wasn't it working for you @mahdidarabi?

davidkornel commented 2 weeks ago

@mahdidarabi Do you use zsh? If yes, the ? char broke the command as it had to be escaped. Like this: kubectl apply -k "github.com/kubernetes-sigs/gateway-api/config/crd?ref=v1.0.0"

mahdidarabi commented 2 weeks ago

Yes, you were right and this command was executed correctly