l8nite / se-133-assertfalse

133 Software Project
0 stars 0 forks source link

createaccount.php - cleanup POST data before manipulation #5

Open Deegrin opened 11 years ago

Deegrin commented 11 years ago

Details

Need to cleanup and sanitize input data before manipulation and storage.

Suggestion

//if first sign up page
if (isset($_REQUEST['inputEmail']) && isset($_REQUEST['inputPassword']) && isset($_REQUEST['typeOptions']) && isset($_REQUEST['inputFirst']) && isset($_REQUEST['inputLast']) && isset($_REQUEST['inputZip'])) {
    //INTERCEPT AND CLEANUP HERE

    $uuid = generateUUID();

    setPassword($redis, $uuid, $_REQUEST['inputPassword']);
    setContact($redis, $uuid, $_REQUEST['inputEmail'], $_REQUEST['inputZip']);
    setProfile($redis, $uuid, $_REQUEST['inputFirst'], $_REQUEST['inputLast'], 'Title', 'Description', $_REQUEST['typeOptions'], $_REQUEST['inputZip']);

    $sid = Session::generateSession($redis, $uuid);
    setcookie('MentorWebSession', $sid, time()-1, "/");
    setcookie('MentorWebSession', $sid, time()+60*60*24*30, "/"); //30 days
    echo $sid;
}

//if second sign up page
if (isset($_REQUEST['inputTitle']) && isset($_REQUEST['inputSummary']) && isset($_REQUEST['inputGoals']) && isset($_REQUEST['inputExperience'])) {
    if (isset($_COOKIE['MentorWebSession'])) {
        //INTERCEPT AND CLEANUP HERE

        $uuid = Session::resolveSessionID($redis, $_COOKIE['MentorWebSession']);

        Profile::updateTitle($redis, $uuid, $_REQUEST['inputTitle']);
        Profile::updateDescription($redis, $uuid, $_REQUEST['inputSummary']);
        setGoals($redis, $uuid, $_REQUEST['inputTitle'], $_REQUEST['inputGoals']);
        setExperience($redis, $uuid, $_REQUEST['inputExperience']);
    } else {
    }
}