search

lVlyke / lithium-ngx-virtual-scroll

A fast and lightweight virtual scrolling solution for Angular that supports single column lists, grid lists and view caching.
MIT License
24 stars 4 forks source link

Support rendering when [itemWidth] has not been defined #15

Closed lincolnthree closed 1 year ago

lincolnthree commented 1 year ago

Since only itemHeight is required for rendering when 'gridList' is false, the virtual-scroll component should probably reflect that in its rendering logic. Let me know if I've misunderstood how this is supposed to work!

lincolnthree commented 1 year ago

I noticed the itemWidth is also used in the placeholder style definition. It may be necessary to account for that by setting width of the placeholder to 100% (or unset), if [itemWidth] is not defined/gridList is false.

lVlyke commented 1 year ago

These changes along with the additional changes discussed above have been merged via #25 and will be released shortly under version 0.3.0.

Thank you for your contribution and supporting this project!