la-haus / flutter-segment

Segment.io library for flutter
MIT License
22 stars 139 forks source link

chore: Modernise Android build config for plugin and example #29

Closed vbuberen closed 2 years ago

vbuberen commented 2 years ago

While going through the source code in the repo I saw that plugin and example app both have quiet outdated Android build configuration and decided to help bring it up to date a little bit.

P.S. pubspec.lock versions changed because I was building the project after my changes and had to do pub.get. Version bump for Dart happened because I use latest stable versions of Dart and Flutter. These updates would need to happen anyway, so didn't revert them.

vbuberen commented 2 years ago

Build Android job fails due to Github Actions using Flutter 2.0.0, which couldn't work with Gradle 7 and newer.

Here is the issue in the Flutter repo with fix, which adds the compatibility: https://github.com/flutter/flutter/pull/79167

Thus, will update version of Flutter used on CI in this PR as well to make all actions pass.

danielgomezrico commented 2 years ago

@vbuberen what are the consequences of updating the library to flutter 3.0?

vbuberen commented 2 years ago

In the context of this PR nothing changes for the project because of building with Dart 2.17 and Flutter 3 as I introduced no new code or features, which appeared only in mentioned releases.

In case you would like to check yourself here are links with release notes descriptions: https://docs.flutter.dev/development/tools/sdk/release-notes/release-notes-3.0.0 https://medium.com/dartlang/dart-2-17-b216bfc80c5d

vbuberen commented 2 years ago

@danielgomezrico Do you you want me to address something else in this PR or it can be merged? Would like to open one more PR with some Segment Android SDK updates, but feel like we might want to merge this one first.

vbuberen commented 2 years ago

Thanks for approval. I was curios more on when this PR will be merged đŸ˜„

danielgomezrico commented 2 years ago

@vbuberen LGTM thanks for opening the PR!