search

la-haus / flutter-segment

Segment.io library for flutter
MIT License
22 stars 139 forks source link

Confusing Documentation needs to be improved #42

Open psovit opened 2 years ago

psovit commented 2 years ago

The package's readme file says something about deprecation in AndroidManifest and Info.plist files. However, it is not clear if the deprecated part is needed in latest versions (for eg: 3.9.0).

Also, looking at the latest example code, it is still using deprecated code.

Can you guys please update the documentation or the example?

Screen Shot 2022-07-01 at 17 36 09
thorgexyz commented 2 years ago

@danielgomezrico Can you give some clarification on whether those steps are still required or not here in this Thread?

danielgomezrico commented 1 year ago

As far as I can understand this deprecated code still works and exists to maintain compatibility, the PR that introduced the setup via code is:

danielgomezrico commented 1 year ago

@psovit have you tried without using the deprecated code to see what happens? please confirm to see if there's an issue or if the compatibility still works fine.

Deprecated means that it still works but will be removed in the future so I dont see any issue in the docs 🤓 , can you confirm that?