search

la-haute-societe / ssh-deploy-release

Deploy releases over SSH with rsync, archive ZIP / TAR, symlinks, SCP ...
https://www.npmjs.com/package/ssh-deploy-release
MIT License
36 stars 10 forks source link

Bug while using mode synchronize #25

Open a-tonchev opened 3 years ago

a-tonchev commented 3 years ago

There is a kind of serious bug while using mode "synchronize",

at first the deployment fails, but it also creates a file in the directory with the characters from the command, including also the password:

Screenshot 2021-02-05 165431

I think it is caused because the password is wrapped with single quote, that will break the open single quote at --rsh

Using mode "archive" works like a charm.

xstable commented 3 years ago

I can confirm the error

nstCactus commented 3 years ago

We've just managed to reproduce this using a password that contains a closing parenthesis ()). I'll try to look into it next week. It seems we'll have to change our password escape strategy.

a-tonchev commented 3 years ago

@nstCactus I tried it with alphanumeric password and it works. But I think it is quite good if we are not limited by that. The password that we used previously had no closing parenthesis, but other special characters, and still don't work.

While fixing this issue please try all the "regular" special characters (#!+^<>/%&$§()[]}{\?`´")

What do you think, when will you be able to fix this problem?

Thanks

xstable commented 3 years ago

Issue still exist in the current Version. @nstCactus did you have an Idea, how to fix that?

nstCactus commented 3 years ago

Sorry I didn't have the time to look into this and I can't give you an ETA. PRs are welcome though!