search

la-jarre-a-son / midi-jar

MIDI Jar is a tool box for musicians, learners, streamers, that want to route MIDI message between devices, and display a piano or chords while playing, and integrate it on a video or on a Twitch stream.
http://midi-jar.ljas.fr/
MIT License
87 stars 9 forks source link

Chord display should understand no 5th chords #18

Open sreich opened 1 year ago

sreich commented 1 year ago

It seems that midi jarr gets confused when you drop the 5th from extended chords

Take an Emaj7 for instance, root position. E, G#, B and D#...

You can see it understand this chord. However, if you remove the 5th(leave out the B) as jazz often does... It gets confused and won't show it as any chord...

But, to my eyes I can see this and understand it's just an Emaj7 without a 5th. What's weird is I've seen it before say "no5" for a chord... So it does kinda understand this concept in some contexts...

ArTiSTiX commented 1 year ago

Hello @sreich, thanks for the feedback.

i did not have time to work on MIDI JAR recently, I’m busy with something else. But fixing some incoherence with the tonaljs library is in my top priority, as I noticed this kind of issues too (like missing chords, incoherent notations, and such). Tonal has been updated so that it can now detect chords with 5th omissions, I’m wondering if I could maybe extend this to allow more omissions (this could be done in the algorithm or in the dictionary). The dictionary is incomplete, and includes some chords notes “no5” (that’s why you may find some), which is kinda redundant with detecting chords omitting 5th. So as soon as I can upgrade all packages (work still pending for months), i’ll be able to fix this. I hope to be able to work on this, but procrastination… But your feedback is a motivation so thanks again !

sreich commented 1 year ago

Okay! No problem, life happens. Glad you're getting to it and planning for it...

Thank you for the fast response and explanation. Take your time. By the time you get to it I'll just be that much better at piano practice to use your app 😉

ArTiSTiX commented 1 year ago

Hello @sreich !

I just finalized the latest release of MIDI Jar 1.5.0, which is a complete rewrite of the chord dictionary used by tonal. Since a lot of chords were missing, and some made no sense to me, i chose to polish all the chords, and complete it as much as possible. It took me some time, and i am pretty sure some chord alterations are missing, but the good thing is that most of it is here. And since i had this "no5" issue in mind, i chose to totally remove the "no5" chords from the dictionary in favor of a better solution: chords can have omissions (non mandatory intervals), not only fifths, but also contextually the 9th, 11th.

I did not implement the mention of the "no5" and such in chord display, since there already are a lot of information displayed on screen.

You can enable the "Allow omissions" option in the chord-display settings, and it should be all good. You can also now choose to display a full chord name, and change the notation.

Planning to add a gameplay option to allow omissions / alterations in Chord Quiz, but i would also like to have an option to require a specific inversion (at least a bass note).

Hope you will appreciate this release, don't hesitate to give feedback if you have any issue with this ticket, otherwise, i'll close it.

sreich commented 1 year ago

Hey, this sound awesome! Sounds like really great improvements, thank you. I've also been enjoying the interface improvements you've been making

I opened #22 because I'm unable to get 1.5.0