search

la10736 / temp_testdir

Simple temp dir manager for testing
Apache License 2.0
2 stars 3 forks source link

Deprecation in favor of tempfile #4

Closed Nukesor closed 2 years ago

Nukesor commented 2 years ago

Hi @la10736

I've noticed that this library hasn't received any updates since over two years.

In order to keep the Rust ecosystem clean, would you mind setting this crate on deprecated, adding a deprecation notice and redirecting to the tempfile project in your README?

la10736 commented 2 years ago

You are right but this crate don't have the same target of tempfile crate. This crate is designed with tests in mind: you can chose temp root dir and you can chose to not delete these file at the end (to analyze the content after tests).

I wrote it for use it in rstest's tests.

Nukesor commented 2 years ago

These are fair points.

I guess it would make sense to patch tempfile with that functionality. I'll check whether they're interested in such behavior and I might create a PR that adds this functionality to tempfile.

Nukesor commented 2 years ago

There are now PRs for both requested features in the tempfile project.

https://github.com/Stebalien/tempfile/pull/170 https://github.com/Stebalien/tempfile/issues/169

la10736 commented 2 years ago

WOW, thanks very much. I'll switch to tempfile and deprecate temp_testdir when your PR will merge and the new version land.

la10736 commented 2 years ago

Ok, thanks for your effort to try to keep things cleaner. Unfortunately I've designed this crate with just tests in mind and and not a general purpose use. I understand that tempfile cannot add these features.