search

la5nta / pat

A cross-platform Winlink client written in Go
https://getpat.io
MIT License
488 stars 86 forks source link

Support Winlink HTML Forms #135

Closed rpettigr closed 3 years ago

rpettigr commented 6 years ago

Having a choice of templates or being able to create your own template for composing messages so that pat can be used for easily sending ICS traffic or other emcomm traffic.

rainerg2000 commented 4 years ago

@martinhpedersen I started adding support for composing messages based on templates. Similar to Winlink. So far it only supports the commandline. I added 'pat composeform'. See this branch https://github.com/rainerg2000/pat/tree/issue/135-support-ics-forms It's not ready for pull request, but feel free to comment. Next steps (whenever I get a round to it)

xylo04 commented 4 years ago

@rainerg2000, did you make progress? I'm inspired to start looking at the web side, and will try to integrate with your work.

xylo04 commented 4 years ago

I see @rainerg2000's branch https://github.com/rainerg2000/pat/commits/issue/135-support-ics-forms has additional progress on both CLI and web.

martinhpedersen commented 4 years ago

Thanks @rainerg2000 :smile:

Feel free to open av PR when you are ready for a proper review of the code. I will have a look at your branch soon :)

rainerg2000 commented 4 years ago

I'm still on it, but it's far from being useful. It looks like I'll be able to finish the work in a couple of weeks. I'm currently working the interesting part where the Winlink form's submit button passes data back to the message compose modal in Pat.

By the way, I wanted to use an accordion, so I first had to migrate jQuery and Bootstrap to recent versions. That part is done. Unfortunately it's on the same branch, and would have to be cherrypicked if you are interested in it for other reasons.

Rainer.

On Sun, Apr 12, 2020 at 2:29 AM Martin Hebnes Pedersen < notifications@github.com> wrote:

Thanks @rainerg2000 https://github.com/rainerg2000 😄

Feel free to open av PR when you are ready for a proper review of the code. I will have a look at your branch soon :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/la5nta/pat/issues/135#issuecomment-612587788, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDCV43UNWDZQCUSEHTTWLRMGCYHANCNFSM4E5SMQRA .

rainerg2000 commented 4 years ago

@xylo04 I overlooked your message from 3 days ago. I'll push my changes more frequently, so that you know where I'm at. I am currently integrating the form filling with Pat's message composer. There is a button on the message composer which let's you choose a form. It opens the form, the user fills it out and clicks 'submit' on the form. Then you're back on on Pat's msg composer, and can post it to the outbox.

If you're interested, you could work on generating the XML attachment that captures the form fields.

Or you could add a feature for viewing a form-based message from the inbox. I have not put any effort into that part.

rainerg2000 commented 4 years ago

@martinhpedersen @xylo04 This is a good version to look at: https://github.com/rainerg2000/pat/commit/4ae27874c8c9720f88ecdbf155b79eb40ed201ad You'll need to download and unzip the Standard_Forms zip from winlink.org and then add a line in Pat's config.json, like: "forms_path": "/Users/rainer/.wl2k/Standard_Forms"

Then go to the message composer dialog, and click the Template button on the bottom.

rainerg2000 commented 4 years ago

@martinhpedersen @xylo04 I still have some loose ends to take care of, but all the features for authoring form-based messages are working now. I have extended the commandline and the web UI. Here's my latest commit: https://github.com/rainerg2000/pat/commit/2b2d63e5ac5746ceecfc605082c5fc1b058caddb Next I'll test message compatibility with RMS Express. Can you help with that ? I don't have much experience with RMS Express.

In the next few days I will create a pull request.

Additional features planned later:

KI7RMJ

xylo04 commented 4 years ago

Yes, I can help with testing against Winlink Express. My personal email is on my GitHub profile, and my Winlink email should be obvious to construct. - K0SWE

xylo04 commented 4 years ago

Pat to Winlink with an ICS 213 looks good. I'll send you one originating from Winlink next; should I send another 213 or can I try a different form?

rainerg2000 commented 4 years ago

go for it, any form works, but Pat can't render it as a form yet.

On Mon, Apr 20, 2020, 13:29 Chris Keller notifications@github.com wrote:

Pat to Winlink with an ICS 213 looks good. I'll send you one originating from Winlink next; should I send another 213 or can I try a different form?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/la5nta/pat/issues/135#issuecomment-616790883, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDCVZSRELLOYGRSIBSIJLRNSWDFANCNFSM4E5SMQRA .

martinhpedersen commented 4 years ago

@rainerg2000 FYI: I'm currently working on a code review of PR #197 . Please don't make changes to that branch until I have completed the review :)

Thanks!

rainerg2000 commented 4 years ago

Thank you. I'll wait. I have a bug fix that deals with form file names that contain spaces (like 'ARC 213 Message Initial Viewer')

rainerg2000 commented 4 years ago

Another issue: Some forms are long names like "BC Initial Impact Assessment Form_Viewer.html". This runs into the 50 char limit for the attachment file name length. RMS Express requires the prefix 'RMS_ExpressForm' on the attachment name to recognize it as a form-based message.

The fix requires a change to https://github.com/la5nta/wl2k-go/blob/master/fbb/message.go