search

la5nta / pat

A cross-platform Winlink client written in Go
https://getpat.io
MIT License
499 stars 86 forks source link

Web GUI: Some connect alias URL parts are dropped/ignored #340

Open oe1rsa opened 2 years ago

oe1rsa commented 2 years ago

When using ax25 connect aliases I observe inconsistent behaviour when used from cli than when used from the web interface. E.g. I have:

"oe1xdu": "ax25://fsk96/OE1XDU-10/OE2XZR-11" in pat configure.

When I pat connect oe1xdu everything works as expected.

But pat http Then in browser: Action->Connect->select alias->oe1xdu fails with Unable to establish connection to remote: No such AX port found

What am I missing here?

oe1rsa commented 2 years ago

I found what I were missing. I had not listed my port under the ax25 entry. Adding the port at least let me connect also from the web interface. Still the behaviour is inconsistent.

martinhpedersen commented 2 years ago

Thanks for reporting this 🙂

We're missing an input field for the axport part of the ax25:// scheme. This is why this part (fsk96) of the URI is lost when loading the alias in the connect modal.

Since the connect URI can have an arbitrary number of transport specific fields, I guess it's naive to assume that the connect modal will have fields for all of them.

I guess we need to fix this by keeping the original (aliased) URI and use this as a base when filling in the values from fields supported by the modal.

martinhpedersen commented 7 months ago

This prevents using the new prehook feature from the web gui. So I think it's about time this is prioritized.