search

la5nta / pat

A cross-platform Winlink client written in Go
https://getpat.io
MIT License
498 stars 86 forks source link

fix tests and compilation with `TAGS=libhamlib` #423

Closed as3ii closed 1 year ago

as3ii commented 1 year ago

Note: this requires the merge of https://github.com/la5nta/wl2k-go/pull/85

as3ii commented 1 year ago

I don't know precisely if this is related to the use of libhamlib, and if this is an issue in pat or in wl2k-go, but sometimes randomly pat starts eating a lot of cpu power. The only way I was able to reproduce consistently this bug was manually disconnecting and reconnecting the usb serial interface to the radio. This is what perf recorded and found when this happens: perf

Tell me if I can do anything to help debug this problem

UPDATE: the up-mentioned problem is a hamlib problem, on the pat side it cannot be fixed when using hamlib as a library

martinhpedersen commented 1 year ago

I don't know precisely if this is related to the use of libhamlib, and if this is an issue in pat or in wl2k-go, but sometimes randomly pat starts eating a lot of cpu power.

Thanks! I don't think i have seen this when Pat is compiled without TAGS=libhamlib. The feature is rarely used and not enabled in the official releases, so I don't think I'll prioritize debugging this any time soon. Feel free to debug further if you feel like it 🙂

PS: Thanks for the PR! ❤️

martinhpedersen commented 1 year ago

I've merged the wl2k-go changes and pulled them into Pat's develop branch. Please rebase this PR on top of develop. Thank you 🙂

martinhpedersen commented 1 year ago

Ooops! I did something wrong while trying to rebase this, and since the PR was automatically closed I no longer have permission to push to your branch.

I'll merge this manually to develop.

Thanks for the PR 😄

martinhpedersen commented 1 year ago

Merged (b62dbc787b294e63e30da568ac3ea423f2abbc97).