search

la5nta / wl2k-go

A Winlink framework for Go.
https://getpat.io
MIT License
50 stars 20 forks source link

Support ARDOP version 2 #54

Closed cbs228 closed 5 years ago

cbs228 commented 5 years ago

This pull request adds support for version 2 of the ARDOP protocol as per #53.

In this implementation, ARDOP 1 and ARDOP 2 are completely separate and have their own packages. While there is great potential for code-sharing among protocol v1 and v2, I anticipate that support for version 1 will eventually be dropped. This will largely eliminate the need to combine or abstract these packages.

The main differences are:

martinhpedersen commented 5 years ago

Thanks for this PR @cbs228 !

I agree with your approach to fork the original ardop package, since ardop 1 most likely will be dropped eventually. Great idea! In the mean time, I can backport any fixes that affects both versions.

Do you mind adding yourself to transport/ardop2/CONTRIBUTORS.md and the Contributors section of README.md?

cbs228 commented 5 years ago

@martinhpedersen,

Thanks for your review! I have added my name to the contributors list. If it's alright with you, I am a little hesitant to share my call on a public forum and codebase, but I am quite willing to share it privately with those who ask.

martinhpedersen commented 5 years ago

@cbs228,

Sure, that is understandable and it is the reason why I ask contributors to add themselves to these files. Thank you!

I will be merging the branch soon, it looks very good to me! I Have some fixes to the original ardop package that will need to be ported, but it should not be a problem.

Thanks again Colin!