search

laCour / slack-night-mode

A Stylus style for easy Slack theming
Creative Commons Zero v1.0 Universal
568 stars 386 forks source link

Dark background for names and emojis #149

Closed jkremser closed 6 years ago

jkremser commented 6 years ago

before: https://i.imgur.com/2gjA3VG.png after: https://i.imgur.com/HcqsqQl.png

cornfeedhobo commented 6 years ago

I think this fixes #132 @laCour could you check this and get it merged?

jkremser commented 6 years ago

I guess, he doesn't want to merge my PRs, because he uses scss for generating these css files. If it's the case, I have no idea why the css files are in the repo (master) itself, because it's pretty confusing for the potential contributors.

@laCour you can for instance let the travis CI to process your SASS assets and push the generated CSS to a branch called dist or something similar.

laCour commented 6 years ago

@Jiri-Kremser That would be why your PRs aren't merged. In hindsight, using CI would be preferred, but now the CSS is relied on and expected to be in master. Perhaps I can leave the existing styles in master for a bit and have a CI service build to a new branch. Thanks for bringing this up.

That said, there is a contribution guide detailing how contributions can and should be made. See #167 for these fixes.