Closed zengshengliu closed 5 years ago
@mastermel Let me know if you have any more questions. I think I am good on this PR (unless I find more missing styling)
@zengshengliu I wonder if you could help me out? I'm attempting to test your PR locally using Stylish and the Slack web client in Chrome. When I attempt to import the transpiled css I get this error. Any ideas?
@mastermel It looks like Stylish doesn't like the class name --active
. Let me see if there is another selector I can use instead, because it does looks like an invalid class name but somehow Slack uses it
@mastermel That the exact selector Slack used by default. I don't think there is another selector we can use. Do you have any suggestion?
@zengshengliu sorry for the late reply! I haven't been able to find another way to override that .channel_header__tab.--active
selector such that it will pass the Mozilla Format 😞
Without being able to do that I'm not sure we'll be able to publish your changes to userstyles.org.
Do you think for the time being you could comment that override out, so that we can get the rest of your updates merged?
@mastermel will do that
@mastermel This PR should be good to merge now.
@zengshengliu @mastermel
I'll be switching to running this fork for some time for some pre-merge testing.
Update App "About" page background, commands, and font color Update App Tabs color Update Thread "footer" color Update Button Attachment color Update Dialog textarea font color Update
c-pillow_file
font color Update Threads banner color Update Threads Flexpane reply box color Update Threads page color (I hate they havep-threads
andp_threads
class 😞) Update Threads app label and timestamp color Update Channel Preview footer color Update Channel Notification Banner color Update Flexpane Close button color Update Multi File Upload dialog color Update File Upload overlay color