laCour / slack-night-mode

A Stylus style for easy Slack theming
Creative Commons Zero v1.0 Universal
568 stars 386 forks source link

"Pasted image at" results hidden (black on black) on black theme #212

Open vinzm opened 5 years ago

vinzm commented 5 years ago

Message "Pasted image at " etc results invisible (dark text on dark background) on the black theme. Attached a couple of screenshot of the same portion w/ and w/o black theme. image image

Otto42 commented 5 years ago

Same thing for screenshots and such.

This seems to be a decent fix.

.c-message_kit__file__meta { 
color: #e6e6e6 
}
vinzm commented 5 years ago

Thanks Otto42 for your reply. Please forgive the newbie questions: is it a suggestion for other developers contributing to this project? Or is it a suggestion for me on how to work around it somehow? In the latter case I wouldn't know how to patch a remote and ajax-loaded css resource just for me...

mastermel commented 5 years ago

This should be corrected in the next theme release!

vinzm commented 5 years ago

Sorry again for yet another newbie question: for what I can understand, no release was ever released (github says: 650 commits, 2 branches, 0 releases, 22 contributors); nevertheless I can use the theme (by pointing to black.css). So, what's the meaning of "in the next theme release"?

vinzm commented 5 years ago

So, what's the meaning of "in the next theme release"?

Now it seems fixed. As an attempt to answer to my question by myself, I guess what lets code-commits "go in production" is when someone pushes the css files built with such fixes to the repository. Thanks everybody!