laCour / slack-night-mode

A Stylus style for easy Slack theming
Creative Commons Zero v1.0 Universal
568 stars 386 forks source link

Fixed for Slack update 4.0.0 #237

Closed NeQuissimus closed 5 years ago

NeQuissimus commented 5 years ago

Fixes taken from https://gist.github.com/micahstubbs/e750e5bb8b6adb7b51a961e57660f710 Fixes #235

All credit goes to @micahstubbs, this is just wrapping their code in a PR

NeQuissimus commented 5 years ago

Note that I could not determine an organizational scheme in the CSS file and hence just pasted :D

mastermel commented 5 years ago

Thanks for submitting the PR @NeQuissimus! For this project we actually just make changes to the files in the ./scss/ directory and then autogenerate all of the .css files. If you'd like to update this PR to make the relevant changes to the scss files and reset what you have for the css we could take a look at it!

For more info, see our contributing guide

NeQuissimus commented 5 years ago

On it, my bad.

mastermel commented 5 years ago

Also, I just pushed a few fixes myself. Make sure you rebase on master before making your changes :)

NeQuissimus commented 5 years ago

I dropped the CSS generation

micahstubbs commented 5 years ago

thanks for picking this up @NeQuissimus 🙏 🙌