search

laanlabs / SCNTechniqueGlow

Basic object glowing outline using SCNTechnique
MIT License
82 stars 12 forks source link

Artifact in the material border #14

Closed abbana closed 4 years ago

abbana commented 4 years ago

Hi,

hope you are good.

I am applying the technique to a SCNPlane and I have an ugly artifact in the border as per screenshot attached.

Can this artifact be removed someway or at least mitigated? technique

cclaan commented 4 years ago

Any chance you can upload a sample project showing this artifact?

abbana commented 4 years ago

Any chance you can upload a sample project showing this artifact?

@cclaan Sure, any SCNPlane or SCNtext nodes shown that behaviour. I have not tested other shapes. It seems to me is function of the NODE in regards to the camera. The above is a SCNPlane and the line is visible on the upper part of the node only, but still not usable.

Regarding the implementation I just

abbana commented 4 years ago

Hi,

issue is on the below line:

if ( maskColor.g > 0.5 ) { return half4(FragmentColor); }

All the rest works as supposed.

Thanks for the good job.

cclaan commented 4 years ago

Were you able to fix it? sorry i haven't had a chance to look into this.

abbana commented 4 years ago

Correct, closing the issue now.