search

laas / metapod

A template-based robot dynamics library
GNU Lesser General Public License v3.0
14 stars 10 forks source link

reorganise tests, to enable testing several models #5

Closed sbarthelemy closed 12 years ago

olivier-stasse commented 12 years ago

Hi Sebastien, I really like the idea. But common.hh has the robot model hard-coded l.33 whereas test_rnea.cc and test_crba.cc are very generic.

We can probably go further by moving common.hh to a specific robot directory, and compile test_rnea.cc and test_crba,cc with different TEST_DIRECTORY and common.hh by changing the include directories.

For now I will pull the commit as it is.

sbarthelemy commented 12 years ago

But common.hh has the robot model hard-coded l.33

Yes, my plan was to add other #include lines while we add robots, since they all have a sub-namespace, there won't be any collision. But this is not very good looking indeed.

We can probably go further by moving common.hh to a specific robot directory, and compile test_rnea.cc and test_crba,cc with different TEST_DIRECTORY and common.hh by changing the include directories.

I'll think about it, I'd like to avoid duplicating the code in common.hh. But it can be easily generated from cmake.

For now I will pull the commit as it is.

Good, thanks

olivier-stasse commented 12 years ago

Test and merged by commit 804a

To keep a linear branch, I will not rely on the github interface to perform the merge.