laas / ros

Entry point for LAAS ROS packages.
1 stars 4 forks source link

Several remote repositories are pointed out by laas-private.rosinstall #4

Open francois-keith opened 11 years ago

francois-keith commented 11 years ago

Hello

The repositories contained in laas-private.rosinstall are located on several repositories:

So, this raises some issues when running the github.com/stack-of-tasks/install-sot script. Since laas-private.rosinstall is used if one has an account on the private part of jrl-umi3218, but not necessarily to the laas internal server, all rthe repositories cannot be downloaded and the rosinstall command crashes.

So here are the questions:

Regards

olivier-stasse commented 11 years ago

I would favor to

  1. move humanoid_motion_planners into Laas.rosinstall
  2. Put vslam_stereo_visibility.git in a different file or remove it until a new closed source repo is used at Laas, or when it will be necessary. The code right now need to be extended and there is no project to do so in a near future.
thomas-moulard commented 11 years ago

Please do not move the humanoid_motion_planners. Even if this is not perfect by now, the goal is to have external users take the laas.rosinstall file and be able to run rosdep install and rosmake / catkin on it and be able to use our software from there. De facto, it excludes software with closed dependency such as this one. Also don't forget that laas.rosinstall is watched by ROS to generate the documentation on Fuerte release on ros.org website.

I would favor the solution of having one rosinstall file per required account. I.e. one for stuff on trac.laas.fr, one for the LIRMM, one for closed-source github.

It will ease the dispatch on the install-sot side and it is not difficult to validate that everything is at its right place by just looking at the url...

olivier-stasse commented 11 years ago

Ok I did not see the dependency to Kineo. Thus I agree with the splitting by file.

olivier-stasse commented 11 years ago

There is one inconsistency: the laas-private.rosinstall points towards public github.com repos which depends upon private repositories. What is the point in letting them on github if there is no open-source alternative ?

thomas-moulard commented 11 years ago

Because we will make it happen one day... ;)

Seriously, now that we have a private subscription, we really have no reason to host any repos on private servers anymore. If possible, I really would like to have a hpp organization, and migrate once and for all everything here even if there is some repos with closed source dependencies.