search

laat / mvn-dl

Download maven artifacts
12 stars 11 forks source link

Snapshot version is undefined in filename #10

Closed DEserrt closed 6 years ago

DEserrt commented 6 years ago

Hello, thanks for the nice library. I currently have a problem though with the filename. When I want to download a snapshot the filename contains undefined. I did test the library like this: mvn-dl groupid:rest-impl:ts:dto:0.0.1 -r repoUrl

I also tried mvn-dl groupid:rest-impl:ts:dto:0.0.1-SNAPSHOT -r repoUrl but that gives me the same result as above.

The artifact in the repo looks like this: `

de.xyz.abc rest-impl 0.0.1-SNAPSHOT dto ts

`

The generated name then looks like this: rest-impl-0.0.1-undefined-dto.ts

I believe this happens because the snapshotVersion in the artifact type is not set. At least I could not find it here on github in the code.

laat commented 6 years ago

Can you verify that the latest published package fixes your issue?

DEserrt commented 6 years ago

Nice, it is fixed with the latest version. Thanks!