search

laat / mvn-dl

Download maven artifacts
12 stars 11 forks source link

Update artifact-url.ts #21

Closed luisanton-io closed 3 years ago

luisanton-io commented 3 years ago

On Windows machines, the path created for download is invalid because the backslash \ is used instead of the slash in the URL path of the artifacts.

laat commented 3 years ago

Thank you. I think the bug is because we use path.join

https://github.com/laat/mvn-dl/blob/6598502eac99f9d303628421bbef5b558b0d97fd/packages/mvn-artifact-url/src/artifact-url.ts#L38-L40

luisanton-io commented 3 years ago

Thanks. Apparently the CI is not passing because of Prettier issues, but this package would be very useful and it would be nice if the fix could be accepted or if I could somehow help in this regard.

Cheers, L

laat commented 3 years ago

I'll look at it Monday when at a proper computer.

laat commented 3 years ago

published in 5.1.1