search

laazyboy13 / linux-csgo-external

Linux x86 cheat/hack for x86 and x64 linux systems (compiled + tested on Xubuntu/Debian(Jessie)/Archlinux) [original author: s0beit, maintainer: laazyboy13 and community]
http://s0beit.me
The Unlicense
15 stars 5 forks source link

Command line toggles #2

Open laazyboy13 opened 8 years ago

laazyboy13 commented 8 years ago

Personally I'd like a radar only command line switch as well. If you've ever had a walls party with your friends it gets pretty OP pretty quick. Also if someone wants to brainstorm a toggle switch that would be equally interesting. If anyone is on IRC and wants to meet up in a channel we can discus the future of the project.

From https://github.com/thisgamesux/linux-csgo-external/issues/15 @foreverska

foreverska commented 8 years ago

Haven't had a chance to try out the toggle, issues with my distro I guess.

If I can suggest a slight tweak to overall code style: Can we put the toggle code in functions and get it it's own source file? I'm not saying we should stick to Linux kernel standards (we'd have to switch languages first) but their stance on function length is:

Functions should be short and sweet, and do just one thing. They should fit on one or two screenfuls of text (the ISO/ANSI screen size is 80x24, as we all know), and do one thing and do that well.

https://www.kernel.org/doc/Documentation/CodingStyle and there's some wisdom in that. Main is a bit unwieldy to read. There's a lot of non-compliant legacy code in there but every bit helps. If you need any help, tell me to get off my butt and file a merge with the completed changes.