search

laazyj / GeorgeCloney

DeepClone, Serialize, DeSerialize extensions useful for testing
Other
17 stars 3 forks source link

Doesn't work with netstandard #5

Open pkese opened 7 years ago

pkese commented 7 years ago

Hi,

I've been using this library for a while and I like ti very much. It is also one of the most popular cloning libraries on nuget.

However I've recently started porting my project to netstandard and the compiler is complaining, that GeorgeCloney needs the old dotnet 4.x. Therefore I'm stuck.

Since there aren't any external dependencies in GeorgeCloney, I think it wouldn't be too hard to target this library to netstandard instead of net 4.x (e.g. usually netstandard 1.3 is the lowest common denomintor that works anywhere).

Any chance you'd be willing to do that.

laazyj commented 7 years ago

Thanks for getting in touch. It's a very good point and something I'll have a look at. But it might take me a few weeks to get to it. If you need it sooner I'd suggest having a go at the change and sending me a pull request.

McDoit commented 4 years ago

@laazyj Is this project dead or any chance to look at the PR? ;)

laazyj commented 4 years ago

build.cmd doesn't support the new project format so AppVeyor CI failed and no new Nuget package published.

I'm not in a position to continue to support this project so I'd be happy to hand over ownership of it to anyone that is interested in maintaining it... @McDoit @pkese ?

steenlknudsen commented 4 years ago

i would like to maintain it

laazyj commented 4 years ago

Hi @steenlknudsen I've added you as a collaborator on the repository. What's your Nuget username so I can make you an owner of the package?