lab-antwerp-1 / home

https://lab-antwerp-1.github.io/home/randomizer
MIT License
3 stars 13 forks source link

Ashenafi: Agile development, 3 weeks #93

Open ashenafykebede opened 2 years ago

ashenafykebede commented 2 years ago

Study Plan

Planning

Developing

ashenafykebede commented 2 years ago

Check-In [Week 1]

Exercise repository ( week 1)

What went well?

What went less well?

I need help with

npm run format and npm run lint:css

Lessons learned

Preparation for Sunday class

colevandersWands commented 2 years ago

When I run npm run format the code gets formatted but failed to pass npm run lint:css . I should edit manually the markdown file to pass linting. Of course the formatting will mess up again. In fact, this happens when you have a longer line and a table with many columns.

🤔 @ashenafykebede, this shouldn't happen. Can you send me a link to the branch where you're having this trouble? I can clone to debug it then update the template

ashenafykebede commented 2 years ago

Dear @colevandersWands

Many of the branches has this problem after the table grew bigger. We can take this branch where I specifically noticed the issue. Especially, the communication.md file as it contains a table with many columns.

To add a bit more about the problem, the npm run format makes the table so good in the markdown file but the table now expands more than 80 lines per row which npm run lint:md fails to pass.

Thank you so much in advance

colevandersWands commented 2 years ago

To add a bit more about the problem, the npm run format makes the table so good in the markdown file but the table now expands more than 80 lines per row which npm run lint:md fails to pass.

thanks for the extra details. I think this is an easy fix in the linting configurations, you can tell it not to check the line-length for tables. Checking now to be sure

colevandersWands commented 2 years ago

🤕 oops, I meant to send a PR with this fix but accidentally merged to your main because I forgot I have write access. anyway, this should fix it!

ashenafykebede commented 2 years ago

Check-In [Week 2]

Exercise repository ( week 1)

What went well?

What went less well?

I need help with

-

Lessons learned

Preparation for Sunday class

ashenafykebede commented 2 years ago

Check-In [Week 3]

Exercise repository ( week 3)

What went well?

What went less well?

I need help with

Lessons learned

-We were able to create a nice homepage by taking feedback and adding modifications to the proposed website design. This is the agile way!

Preparation for Sunday class