search

lab-cosmo / chemiscope

An interactive structure/property explorer for materials and molecules
http://chemiscope.org
BSD 3-Clause "New" or "Revised" License
119 stars 29 forks source link

Documentation cleanup #310

Closed ceriottm closed 7 months ago

ceriottm commented 8 months ago

New PR to address the documentation issues that were left open by a prematurely merged PR. @rosecers could you please use this to Fix #295 ? perhaps a UWMadison student could do this?

Also Fixes #295 broken link in the load/save form

Also Fixes #259 - at least it should

rosecers commented 8 months ago

Hi @ceriottm! In general it looks good, although I'll note that the standalone link gives me this:

Screen Shot 2023-11-13 at 8 59 54 AM

@saswatnayak1998 is also going to give a look this morning, then should be almost ready

ceriottm commented 7 months ago

Hi @ceriottm! In general it looks good, although I'll note that the standalone link gives me this:

Screen Shot 2023-11-13 at 8 59 54 AM

@saswatnayak1998 is also going to give a look this morning, then should be almost ready

ok this is due to the browser ignoring the download attribute when opening a link from a different source. It works when the documentation is deployed on chemiscope.org and not locally. I'll merge now, feel free to open another PR if you want to further polish the docs