search

lab-cosmo / chemiscope

An interactive structure/property explorer for materials and molecules
http://chemiscope.org
BSD 3-Clause "New" or "Revised" License
131 stars 32 forks source link

Python-side selection #316

Closed ceriottm closed 4 months ago

ceriottm commented 10 months ago

Traitlet-based synchronization of the selected structure. Facilitates interaction with other ipywidgets. We should also use this to Fix #244 for good.

Luthaf commented 9 months ago

What's the status on this? Should we close & reopen later when someone has time to implement it?

ceriottm commented 9 months ago

well, it's actually kind of working. there are some problems handling multiple viewers and the synchronization with the map. I think it however might be good to keep this on hold until we have done something about #326, as I think one underlying issue is that the settings synchronization mechanism is not well documented and so there's a lot of guesswork.

Luthaf commented 9 months ago

Sure, I'm just trying to clear PR no-one is working on. Should I close this PR and keep the branch around?

ceriottm commented 9 months ago

I'd leave it on if you don't mind. I think it might take half an hour if we look at it together.

Luthaf commented 4 months ago

We'll re-open this whenever we have time for it!