search

lab-cosmo / chemiscope

An interactive structure/property explorer for materials and molecules
http://chemiscope.org
BSD 3-Clause "New" or "Revised" License
131 stars 32 forks source link

Atoms color fixes #322

Closed Luthaf closed 9 months ago

Luthaf commented 9 months ago

Fix #319 and some related code and layout cleanup.

@MaximeScope could you give this a look and check that everything works as intended?

ceriottm commented 9 months ago

Ghost environments are fixed, had some issue with the color scale remaining even after switching to element coloring, but might have been down to non-updated widgets. when switching environments on and off and then on, it doesn't switch to environment highlighting until an atom is clicked on, IDK if that is intended or a bug

Luthaf commented 9 months ago

had some issue with the color scale remaining even after switching to element coloring, but might have been down to non-updated widgets

If you manage to reproduce let me know I'll try to fix it.

Luthaf commented 9 months ago

when switching environments on and off and then on, it doesn't switch to environment highlighting until an atom is clicked on, IDK if that is intended or a bug

Should be fixed now, we just go back to the previously selected center

ceriottm commented 9 months ago

when switching environments on and off and then on, it doesn't switch to environment highlighting until an atom is clicked on, IDK if that is intended or a bug

Should be fixed now, we just go back to the previously selected center

Works.

ceriottm commented 9 months ago

fixed legend layout. @Luthaf only thing I can't seem to manage to fix is the position of the modal, that at least on chrome seem to ignore completely what goes into positionsettingsrectangle

ceriottm commented 9 months ago

Fixed also the alignment I think

Luthaf commented 9 months ago

I cleaned up the commits, this is good to go for me!