Closed cbenmahm closed 4 years ago
This has been solved in PR #265
It has? How? I've been getting the same error (and have to set LD_LIBRARY_PATH
explicitly each time as a workaround)
it is in fixed in #265
Ok, but what was the actual problem? Where was this introduced (so we know not to do it again)?
the several RPATH were overwritten over one another instead of being appended.
It should have been fixed as a separated PR though. Giant PR with multiple unrelated changes are not ideal for review and knowing why/when a given change was made
I agree in principle, but what do we do about it? Avoid changing cmake parameters in unrelated pull requests?
Send different PR for unrelated changes would be my preferred solution 😃. I often change branches while working on a feature to send a separate refactoring/cleanup/fix PR.
Yep, though it can be a pain if you have features that depend on one another (or if you want to test a combination of features in development). I know it can be done with some git-fu, but learning that requires a dedication of time and effort many developers on this project are unwilling or unable to invest.
Well, I would disagree that learning said git-fu is harder than learning how to use VASP or LAMMPS. Anyway, my point is more "please try to send small PR containing only one change", but I should survive even if this is not followed 😄
Hello!
I installed librascal using
pip
as instructed in the README file:pip install .
.I had no problem importing rascal:
import rascal
. However, I was not able to import theSphericalInvariants
representation orrepresentations
. I attach the error message for reference.`ImportError Traceback (most recent call last)