search

lab-cosmo / sphericart

Multi-language library for the calculation of spherical harmonics in Cartesian coordinates
https://sphericart.readthedocs.io/en/latest/
MIT License
73 stars 13 forks source link

Lint `sphericart-jax` #128

Closed frostedoyster closed 3 months ago

frostedoyster commented 4 months ago

As in the title

github-actions[bot] commented 4 months ago

Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping wheels.zip and using pip to install the file matching your system

Luthaf commented 4 months ago

The remaining error is 

lint: commands[0]> flake8 python setup.py sphericart-torch/python sphericart-torch/setup.py sphericart-jax/python sphericart-jax/setup.py
sphericart-jax/setup.py:13:1: E302 expected 2 blank lines, found 1
sphericart-jax/setup.py:17:5: E303 too many blank lines (2)

If you don't see this locally, you might have an older version of the code. You could try to remove the .tox folder and run again.

frostedoyster commented 4 months ago

I tried but it's more subtle... these errors make no sense if you go and look at the file...