Use JSON::PP not new dependency JSON

lab-measurement / Lab-Measurement

Lab::Measurement allows to perform test and measurement tasks with Perl scripts.

https://www.labmeasurement.de/

Other

10 stars 12 forks source link

Use JSON::PP not new dependency JSON #88

Open mohawk2 opened 2 weeks ago

mohawk2 commented 2 weeks ago

Without this change, 00-load.t fails. Please merge and release it, as this is currently breaking PDL's downstream-dependencies CI. I don't know how it passed yours, since it looks like the Bluefors file last got modified last year.

This is none of my business, but I see you have a lot of branches that are quite old; it might be beneficial to delete those?

mohawk2 commented 2 weeks ago

Just looking at the diff with your last release; it seems you dropped JSON, and added JSON::PP, as a dep: https://metacpan.org/release/AKHUETTEL/Lab-Measurement-3.920/diff/AKHUETTEL/Lab-Measurement-3.910 (you also dropped Mia Schambeck as an author)

I don't use Dist::Zilla, and this sort of thing is why ;-)

mohawk2 commented 1 week ago

@akhuettel Until this is merged and released, this module will not get tested against changes to PDL, as I don't want false failures in PDL's downstream continuous integration (CI).