search

lab11 / eagle

Custom scripts and libraries for Eagle PCB
62 stars 119 forks source link

eagle renumber suggested prefix suggestion incorrect #9

Open nealjack opened 7 years ago

nealjack commented 7 years ago

well this is just wrong:

The following parts have different suffixes: C22 : 3.3 nF, C3 : 3.3 nF, C7 : 3.3 nF, C20 : 3.3 nF, C27 : 3.3 nF, C46 : 474 nF, C47 : 800 nF And would look like this with suffix correction: C22 : 3.3 uF, C3 : 3.3 uF, C7 : 3.3 uF, C20 : 3.3 uF, C27 : 3.3 uF, C46 : 474 uF, C47 : 800 uF

adkinsjd commented 7 years ago

This is a pretty scary bug. Can you isolate the logic in the script that makes that decision?

On Mar 16, 2017 7:16 PM, "Neal Jackson" notifications@github.com wrote:

well this is just wrong:

The following parts have different suffixes: C22 : 3.3 nF, C3 : 3.3 nF, C7 : 3.3 nF, C20 : 3.3 nF, C27 : 3.3 nF, C46 : 474 nF, C47 : 800 nF And would look like this with suffix correction: C22 : 3.3 uF, C3 : 3.3 uF, C7 : 3.3 uF, C20 : 3.3 uF, C27 : 3.3 uF, C46 : 474 uF, C47 : 800 uF

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lab11/eagle/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIJUOXDL9HlwLuBMPoyQY0qDJI49MMUks5rmezjgaJpZM4MgGXg .

ppannuto commented 7 years ago

I think everything assumes no spaces between number and unit On Thu, Mar 16, 2017 at 22:16 Neal Jackson notifications@github.com wrote:

well this is just wrong:

The following parts have different suffixes: C22 : 3.3 nF, C3 : 3.3 nF, C7 : 3.3 nF, C20 : 3.3 nF, C27 : 3.3 nF, C46 : 474 nF, C47 : 800 nF And would look like this with suffix correction: C22 : 3.3 uF, C3 : 3.3 uF, C7 : 3.3 uF, C20 : 3.3 uF, C27 : 3.3 uF, C46 : 474 uF, C47 : 800 uF

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lab11/eagle/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUt3jyLXQ4iwadIeutpNZfwm3wF_zLdks5rmezigaJpZM4MgGXg .