lab11 / summon

Browser for the Local Web of Things
18 stars 7 forks source link

Handle devices that change their advertisements #3

Closed bradjc closed 9 years ago

bradjc commented 9 years ago

Devices like BLEES alternate between eddystone and data advertisements, and it seems summon groups by ID based on the first advertisement, and doesn't check for subsequent advertisements.

brghena commented 9 years ago

Seconded. This makes summon look really unresponsive. How hard would this be to fix? On Oct 7, 2015 2:09 PM, "Brad Campbell" notifications@github.com wrote:

Devices like BLEES alternate between eddystone and data advertisements, and it seems summon groups by ID based on the first advertisement, and doesn't check for subsequent advertisements.

— Reply to this email directly or view it on GitHub https://github.com/lab11/summon/issues/3.

tzachari commented 9 years ago

New update pushed to the play store handles changing advertisements.

bradjc commented 9 years ago

So this appears to use the most recent advertisement, which is not what we need. If the peripheral ever sends an eddystone adv, summon should use that, and ignore future advertisements.

Now BLEES devices show up on the list, then disapear, then come back, as different advertisements come in.

tzachari commented 9 years ago

Updated and verified with Powerblade. If a BLE device is detected, it will sit in the "Other Devices" list until it sees a Summon-compatible ad. Depending on how often advertisements are changing, it may take a while for this to happen. I will experiment with increasing refresh rate for quicker detection.