Use of treq instead of txrequests causes MailNotifier to stop working

[mrstanwell]

I don't know that this is an issue so much as a point of information.

GiteaStatusPush apparently wants either txrequests or treq. The treq package depends on pyOpenSSL, pyasn1, and pyasn1-modules, and I found (through a laborious process of trial and error) that after all of those are installed, buildbot's MailNotifier stops working because the twisted.mail.smtp ESMTPSender can't connect to the server. If I uninstall those packages again and install txrequests instead, both GiteaStatusPush and ESMTPSender work again.

To reproduce using python 3.6.9:

• create a venv, activate it, set up pip
• pip install buildbot[bundle]==2.8.4 requests buildbot-gitea
• pip install treq (Note that you have to install the buildbot bundle first, which I think installs TLS packages that will make treq install the pkgs above that break SMTP. If you just add it to the line with the buildbot bundle, it doesn't detect the TLS and won't install the other dependencies, and without those GiteaStatusPush will fail if you're trying to do anything over TLS.)
• restart buildbot, then trigger something that will fire the MailNotifier.

Alternatively, using txrequests instead of treq appears to work fine.

[pampersrocker]

This comes from somewhere inside buildbot and has nothing to do with the plugin. This also happens when you try to setup OAuth. treq implementation seems to be broken in buildbot, although it is recommended in the documentation.

[mrstanwell]

Yeah, I realize that this issue isn't caused by the gitea plugin itself. I lost most of an afternoon trying to figure out why MailNotifier had suddenly stopped working just because I'd started using GiteaStatusPush. (I've been using the gitea webhook for some time with no issues.) I just wanted to post my findings somewhere in case somebody else comes looking for a solution to the same problem.

I'll go ahead and close it out, since I don't think there's much to do here. But perhaps someone else will find the tip useful.