lab313ru / ghidra_psx_ldr

Sony Playstation PSX executables loader for GHIDRA
243 stars 32 forks source link

Tomb Raider: Chronicles Symbols not fully applied. #20

Open Gh0stBlade opened 4 years ago

Gh0stBlade commented 4 years ago

Tomb Raider: Chronicles gets an error when the main binary is analysed.

image

Sample files attached: TRC.zip

lab313ru commented 4 years ago

Don't you use SYM file, just an original binary?

Gh0stBlade commented 4 years ago

I use both of course. I get errors when analysing.

lab313ru commented 4 years ago

This problem happens because "generic_clib/crypto.h/functions" contains a function definition named "m", and this name is also mentioned in SYM file at offset 0x00000000. Ghidra tries to apply a function definition "m" at the offset 0x00000000 and fails.

To fix it I must report it to Ghidra's github, it's not my fault.

lab313ru commented 4 years ago

https://github.com/NationalSecurityAgency/ghidra/issues/1560

lab313ru commented 4 years ago

So, if you want some fast fix, rename "m" at 0x00000000 offset to smth else.

Gh0stBlade commented 4 years ago

Yes i tried that but it also looks like some symbols are still incorrectly applied?

Cheers.

lab313ru commented 4 years ago

Yeah, it can happen. I'm working on fixing SYM loading.