search

lab313ru / ghidra_psx_ldr

Sony Playstation PSX executables loader for GHIDRA
231 stars 31 forks source link

Allow manual psyq selection when autodetection fails #41

Closed njfox closed 3 years ago

njfox commented 3 years ago

This adds dialogs when DetectPsyQ.getPsyqVersion() fails to identify the PsyQ version that prompt the user to select the version manually from a list of PsyQ versions that we have signatures for. I ran into this problem when analyzing a game that used PsyQ 3.6 but didn't have exactly the bytes specified in VERSION_BYTES, and I didn't want to loosen the version mask to just 0xFF 0xFF, since that could result in too many false positives.

I decided to hack a trailing "0" to satisfy the subversion detection on line 256 but let me know if that's too ugly for you.

detect-psyq selectpsyq

njfox commented 3 years ago

Well, I just figured out how to specify the version in the Ghidra UI after loading the binary, so this PR probably isn't worth merging. Let me know if you disagree and want to reopen it.