search

lab313ru / ghidra_psx_ldr

Sony Playstation PSX executables loader for GHIDRA
236 stars 31 forks source link

Loading pre-GTE macro project in latest version (v6.3) does not apply GTE macros as described. #55

Closed Kneesnap closed 2 years ago

Kneesnap commented 2 years ago

It seems like the feature to auto-upgrade projects to include GTE macros is not working in the latest version (v6.3).

Both of these screenshots have been taken from the same Ghidra Project, same Ghidra instance.

What I get if I open my existing ghidra binary instance, which I have documented: image

What I get if I load the executable from scratch in Ghidra (In the same project, just a new binary loaded.): image

Kneesnap commented 2 years ago

Hmm. Okay, slight update.

I read this note on the release page: If your project was created in the version before one with GTE macroses support, the loader will automatically upgrade it.

Thus, I assumed it would automatically upgrade. But, looking at README.MD, it looks like you're supposed to re-analyze then manually re-decompile all of the parts of the project that need updating. Which is it?

lab313ru commented 2 years ago

Haha, yes, it's misleading. The order is to reanalyze, undefine a required block of code (with gte usage), then define again.

On January 29, 2022 4:26:26 AM Kneesnap @.***> wrote:

Hmm. Okay, slight update. I read this note on the release page: If your project was created in the version before one with GTE macroses support, the loader will automatically upgrade it. Thus, I assumed it would automatically upgrade. But, looking at README.MD, it looks like you're supposed to re-analyze then manually re-decompile all of the parts of the project that need updating. Which is it? — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Kneesnap commented 2 years ago

Gotcha. It seemed like I didn't actually need to undefin / redefine any code. But it's working now, so thanks!

On Fri, Jan 28, 2022, 10:24 PM Vladimir Kononovich @.***> wrote:

Haha, yes, it's misleading. The order is to reanalyze, undefine a required block of code (with gte usage), then define again.

On January 29, 2022 4:26:26 AM Kneesnap @.***> wrote:

Hmm. Okay, slight update. I read this note on the release page: If your project was created in the version before one with GTE macroses support, the loader will automatically upgrade it. Thus, I assumed it would automatically upgrade. But, looking at README.MD, it looks like you're supposed to re-analyze then manually re-decompile all of the parts of the project that need updating. Which is it? — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/lab313ru/ghidra_psx_ldr/issues/55#issuecomment-1024847257, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYMCMTVQH5BV3R43GTDUYOB2ZANCNFSM5NCGKDXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>