Dev- and Production-Version

labadserver / Adplayer

Adplayer reference implementation

https://github.com/labadserver/Adplayer/wiki

Other

28 stars 11 forks source link

Dev- and Production-Version #113

Closed bmonaumann closed 11 years ago

bmonaumann commented 12 years ago

In respect to issue #104 we should think about two different versions of the adplayer.

Dev-Version (adplayer.dev.js)

no compression
log messages are active

Prod-Version (adplayer.min.js)

is minified
log messages will be commented out before compression, to reduce file size (see https://github.com/labadserver/Adplayer/issues/104#issuecomment-6353057)

What do you think?

olwa commented 12 years ago

I'm added some essential console log outputs to the Adplayer. The Output will one be shown in the console if the parameter adpdebug is set. So we can debug the adplayer even if there are errors in the live scenario.

I will commit the changes later.

olwa commented 12 years ago

The Logs are in V 2.0. At this time, the console logs were only shown when there is no iframe in the chain. We have to discuss if we want iframe support for debugging. If so, we can add a postMessage handling to solve this.

dhellmuth commented 11 years ago

Telco 26.11.2012: actual solution is ok, ticket closed