search

labbsr0x / whisper

A cloud-native Identity and OAuth Provider implemented with Golang and ORY Hydra
MIT License
12 stars 4 forks source link

Graceful shutdown #48

Closed VerasThiago closed 4 years ago

VerasThiago commented 4 years ago

Guided by Gorilla Mux documentation, I implemented the graceful shutdown of Whisper HTTP server.

Now WebBuilder Flags have a new flag called ShutdownTime, that is the deadline time that Whisper HTTP server needs to wait to gracefully shutdown.

eabili0 commented 4 years ago

Hi, @VerasThiago! Thanks for your contribution!

  1. Before submitting your PRs, please open up an issue so we can discuss if there is in fact a need for making such changes to our codebase;

  2. We document whisper's usage at the README.md file; could you please update our README to describe the newly added shutdown-time flag?

Thanks!

VerasThiago commented 4 years ago

Hi, @abilioesteves!

I will create this issue right now, so then we can discuss.

VerasThiago commented 4 years ago

Hi, @VerasThiago! Thanks for your contribution!

  1. Before submitting your PRs, please open up an issue so we can discuss if there is in fact a need for making such changes to our codebase;
  2. We document whisper's usage at the README.md file; could you please update our README to describe the newly added shutdown-time flag?

Thanks!

@abilioesteves, I got a little bit confused because the second point addressed says to update the README in order to describe the new flag, but I didn't find the section that describes each flag, only how to serve whisper locally (this section I added the new flag usage).

Screen Shot 2019-10-31 at 13 41 11

The description of the new flag was written in ./whisper serve -h as follow:

Screen Shot 2019-10-31 at 13 37 03
eabili0 commented 4 years ago

Yes, I was referring to the Try it yourself section We should update that to add the new flag. Any further thoughts on how to improve our Readme will be highly appreciated. Thanks!

eabili0 commented 4 years ago

Fix #49