Closed iK4tsu closed 3 years ago
Merging #41 (7d1384f) into main (5ae2f40) will increase coverage by
0.23%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 19.28% 19.52% +0.23%
==========================================
Files 19 19
Lines 223 251 +28
==========================================
+ Hits 43 49 +6
- Misses 180 202 +22
Flag | Coverage Δ | |
---|---|---|
unittests | 19.52% <ø> (+0.23%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...urce/gboardforensics/gatherers/expressionhistory.d | 0.00% <ø> (ø) |
|
source/gboardforensics/analysis/package.d | 0.00% <0.00%> (ø) |
|
source/gboardforensics/models/clipboard.d | 100.00% <0.00%> (ø) |
|
source/gboardforensics/gatherers/clipboard.d | 0.00% <0.00%> (ø) |
|
source/gboardforensics/utils/serialization.d | 80.00% <0.00%> (+30.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5ae2f40...7d1384f. Read the comment docs.
@iK4tsu I tested on my local machine. The behaviour was not entirely correct as the last_event_millis
should report the last timestamp. Added MAX()
function and amended the commit. Please take a look
@iK4tsu I tested on my local machine. The behaviour was not entirely correct as the
last_event_millis
should report the last timestamp. AddedMAX()
function and amended the commit. Please take a look
Yes, that should be the correct behavior. I think it looks good.
Please test this change as I do not have an expression history with enough data to do it.